feat: add C implementation for stats/base/ndarray/dminsorted by Om-A-osc · Pull Request #10134 · stdlib-js/stdlib

Om-A-osc · 2026-02-07T07:21:42Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

task: lint_filenames
status: passed
task: lint_editorconfig
status: passed
task: lint_markdown
status: passed
task: lint_package_json
status: passed
task: lint_repl_help
status: na
task: lint_javascript_src
status: passed
task: lint_javascript_cli
status: na
task: lint_javascript_examples
status: na
task: lint_javascript_tests
status: passed
task: lint_javascript_benchmarks
status: na
task: lint_python
status: na
task: lint_r
status: na
task: lint_c_src
status: passed
task: lint_c_examples
status: passed
task: lint_c_benchmarks
status: passed
task: lint_c_tests_fixtures
status: na
task: lint_shell
status: na
task: lint_typescript_declarations
status: passed
task: lint_typescript_tests
status: na
task: lint_license_headers
status: passed

Resolves NA

Description

This pull request adds a native C implementation for stats/base/ndarray/dminsorted.
The contribution includes C source code, native tests, benchmarks, and examples, along with updates to the C APIs section in the README. All tests and benchmarks pass successfully.

Related Issues

This pull request has the following related issues:

NA

Questions

No.

Other

No.

Checklist

Read, understood, and followed the contributing guidelines.

AI Assistance

Yes
No

Disclosure

No AI assistance was used in authoring this pull request. All code, tests, benchmarks, documentation, and analysis were written manually.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2026-02-07T07:24:41Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/ndarray/dminsorted	$\color{green}170/170$ $\color{green}+0.00%$	$\color{green}7/7$ $\color{green}+0.00%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{green}170/170$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Sachinn-64

@Om-A-osc Changes are still pending in benchmark.js, test.js, and test.main.js. Refer #10039 .

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Om-A-osc · 2026-02-08T16:19:07Z

@Sachinn-64 Thank you for pointing it out. I have made the necessary changes.

Sachinn-64 · 2026-02-08T20:44:06Z

@Om-A-osc Could you address these changes here too: #10143.

Om-A-osc · 2026-02-09T04:38:46Z

@Sachinn-64 Done!

Sachinn-64 · 2026-02-09T10:28:06Z

lib/node_modules/@stdlib/stats/base/ndarray/dminsorted/benchmark/c/benchmark.length.c

+	for ( i = 0; i < len; i++ ) {
+		data[ i ] = ( rand_double() * 20000.0 ) - 10000.0;
+	}
+	qsort( data, len, sizeof( double ), compare );


Suggested change

qsort( data, len, sizeof( double ), compare );

Same here, I don’t think we need this part.

@kgryte @Sachinn-64 package expects sorted data. If we remove the sorting logic then input will be invalid. What do you suggest ?
One thing we can do is fill the array like for ( i = 0; i < len; i++ ) { x[ i ] = i; }. should i go ahead with it ?

Sachinn-64 · 2026-02-09T10:34:25Z

lib/node_modules/@stdlib/stats/base/ndarray/dminsorted/benchmark/c/benchmark.length.c

+	for ( i = 0; i < len; i++ ) {
+		data[ i ] = ( rand_double() * 20000.0 ) - 10000.0;
+	}


Suggested change

for ( i = 0; i < len; i++ ) {

data[ i ] = ( rand_double() * 20000.0 ) - 10000.0;

}

We could use a simple for loop here!

Sachinn-64 · 2026-02-09T17:01:41Z

lib/node_modules/@stdlib/stats/base/ndarray/dminsorted/benchmark/c/benchmark.length.c

+/**
+* Compares two double-precision floating-point numbers.
+*
+* @param a      first value
+* @param b      second value
+* @return       comparison result
+*/
+static int compare( const void *a, const void *b ) {
+	const double *x = (const double *)a;
+	const double *y = (const double *)b;
+	if ( *x < *y ) {
+		return -1;
+	}
+	if ( *x > *y ) {
+		return 1;
+	}
+	return 0;
+}
+
+/**


Suggested change

/**

* Compares two double-precision floating-point numbers.

*

* @param a first value

* @param b second value

* @return comparison result

*/

static int compare( const void *a, const void *b ) {

const double *x = (const double *)a;

const double *y = (const double *)b;

if ( *x < *y ) {

return -1;

}

if ( *x > *y ) {

return 1;

}

return 0;

}

/**

@kgryte I don’t think this part is necessary here

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Om-A-osc · 2026-02-09T18:29:38Z

@Sachinn-64 I have removed the sorting code. I now use a simple for loop to fill array in sorted order in the c benchmark file.

Sachinn-64 · 2026-02-09T19:09:06Z

For now, aside from the C benchmarks, this PR looks good. Let’s see what Athan suggests.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 7, 2026

Sachinn-64 requested changes Feb 8, 2026

View reviewed changes

Om-A-osc added 2 commits February 8, 2026 21:39

Om-A-osc requested a review from Sachinn-64 February 9, 2026 09:23

Sachinn-64 reviewed Feb 9, 2026

View reviewed changes

Sachinn-64 changed the title ~~feat: add c implementation for stats/base/ndarray/dminsorted~~ feat: add C implementation for stats/base/ndarray/dminsorted Feb 9, 2026

Om-A-osc requested a review from Sachinn-64 February 9, 2026 18:29

Sachinn-64 mentioned this pull request Feb 10, 2026

Office Hours (2026-02-10) stdlib-js/meetings#80

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add C implementation for stats/base/ndarray/dminsorted#10134

feat: add C implementation for stats/base/ndarray/dminsorted#10134
Om-A-osc wants to merge 5 commits intostdlib-js:developfrom
Om-A-osc:feat/stats-base-ndarray-dminsorted-c

Om-A-osc commented Feb 7, 2026

Uh oh!

stdlib-bot commented Feb 7, 2026 •

edited

Loading

Uh oh!

Sachinn-64 left a comment

Uh oh!

Om-A-osc commented Feb 8, 2026

Uh oh!

Sachinn-64 commented Feb 8, 2026

Uh oh!

Om-A-osc commented Feb 9, 2026

Uh oh!

Sachinn-64 Feb 9, 2026

Uh oh!

Om-A-osc Feb 9, 2026 •

edited

Loading

Uh oh!

Sachinn-64 Feb 9, 2026

Uh oh!

Sachinn-64 Feb 9, 2026

Uh oh!

Om-A-osc commented Feb 9, 2026

Uh oh!

Sachinn-64 commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Om-A-osc commented Feb 7, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Sachinn-64 left a comment

Choose a reason for hiding this comment

Uh oh!

Om-A-osc commented Feb 8, 2026

Uh oh!

Sachinn-64 commented Feb 8, 2026

Uh oh!

Om-A-osc commented Feb 9, 2026

Uh oh!

Sachinn-64 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Om-A-osc Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sachinn-64 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Sachinn-64 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Om-A-osc commented Feb 9, 2026

Uh oh!

Sachinn-64 commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented Feb 7, 2026 •

edited

Loading

Om-A-osc Feb 9, 2026 •

edited

Loading